Add more cell colors to formatting #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- commands.js - Add more key binding for cell color formating - sheet_actions.js - New Single function to change cell colors - Remove colors property from SheetActions.menu as it's not useful anymore - ui.js - Increase maxBindLength to 6 for supporting all color commands - README.md - Update with documentation for new color commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought the cell color options was limited so added more cell color options 😃
Also I felt like the
colorCell"Color"functions can be concluded into a single function, so concluded all of those into a new singlecolorCellfunction and removed no-more-useful code.And lastly increased
maxKeyBindLengthto accommodate new cell color key bindings.Hoping to see this come as a official chrome extension or a sheets add-on if that's possible
-- Cheers