Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and rename red-hat.yml to redhat.yml #1240

Closed
wants to merge 1 commit into from
Closed

Update and rename red-hat.yml to redhat.yml #1240

wants to merge 1 commit into from

Conversation

krishnatre-s
Copy link
Contributor

@krishnatre-s krishnatre-s commented Mar 17, 2020 •
edited
Loading

Adds or updates the following companies, events, or universities:

Checklist

Company updates

  • I have put the most recent relevant date in the "Last Update" column
  • I have linked to the article about the change, not the company's homepage (Please put N/A if there is no public post)

Event updates

  • I have linked to the article about the change, not the event's homepage

University updates

  • I have linked to the article about the change, not the university's homepage

@krishnatre-s krishnatre-s mentioned this pull request Mar 17, 2020
Open
drewbrew
drewbrew reviewed Mar 17, 2020
View reviewed changes
Copy link
Collaborator

@drewbrew drewbrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, two questions here:

  1. Why do you want to rename the file? The company has a space in the name, so kebab-case seems appropriate.
  2. AFAIK, Mandatorily isn't a word, so what does that offer on top of just being required?

Thanks!

@krishnatre-s
Copy link
Contributor Author

Got a wrong understanding from #819. Sorry - reject this PR, please, @drewbrew

@drewbrew
Copy link
Collaborator

It's all good. Thanks for addressing the issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbrew drewbrew drewbrew left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krishnatre-s @drewbrew