Optionally disable animating items when dropping #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this is enabled, items beneath the dropped item re-animate into place after the user drops something in the list. This feels like a bug, but I went ahead and made it an option in the interest of not changing existing behavior for existing users of the library. Note that the duration is set to 1 because the render animation system ends up throwing an exception if it's set to 0. I tried replacing the AnimatedSize widget entirely when this option was set, but swapping an animated widget in right when we want it to animate means it doesn't know what its previous size was, so it can't animate. In other words: a duration of 1 feels wrong, but it's there for a reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this is enabled, items beneath the dropped item re-animate into
place after the user drops something in the list. This feels like a bug,
but I went ahead and made it an option in the interest of not changing
existing behavior for existing users of the library.
Note that the duration is set to 1 because the render animation system
ends up throwing an exception if it's set to 0. I tried replacing the
AnimatedSize widget entirely when this option was set, but swapping an
animated widget in right when we want it to animate means it doesn't
know what its previous size was, so it can't animate. In other words: a
duration of 1 feels wrong, but it's there for a reason.