Dataspaces sync #37
Closed
Dataspaces sync #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Add syncds_ref() function to return sync_op.ds_comp[] address 3. Add dsgrpc_server_completion RPC call function to receive RPC call from server. And change sync_op.ds_comp[] value 4. Fixed dcg_obj_sync() behavior. Release when both client and server completed.
2. Update dsgrpc_obj_put() function, add sync_op pointer to msg buf
…lient side sync operator pointer
2. Add sync_comp_ptr attribute in rpc_cmd structure
|
fixes #26 |
…er of client synchronization lock
Add dcgrpc_server_completion() function which will release synchronization lock when received rpc function call from server obj_put_completion()
…erver has completed processing data Add callback function obj_put_sync_completion() to free msg that created in obj_put_completion()
|
This was merged in manually for the 1.7 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ds_gspace.c, I add ds_comp flag to structure sync_op. This flag holds the data process status, client-side ds_put request won't complete until this flag become true. The client sent this flag address with object data to the server. Once the server has completed processing the object data, from obj_put_complete() send rpc request along with that flag address back to the client side. Then dcgrpc_server_completion() modify the flag and release client sync lock.
PS: my ds_comp flag is similar to the opid flag in structure sync_op. I feel there must be some bugs on current opid flag implementation. It is better to find out what cause it fail, since my implementation brings an extra RPC communication.