Bug fix: add x to payoffFuncion arguments#9
Open
AJnsm wants to merge 1 commit intophilipp-zahn:masterfrom
Open
Bug fix: add x to payoffFuncion arguments#9AJnsm wants to merge 1 commit intophilipp-zahn:masterfrom
AJnsm wants to merge 1 commit intophilipp-zahn:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of problem
The payoff function used by the
singleDecisionPriorVerbosegame explicitly depends onx. When the game is written in reduced form (singleDecisionPriorReduced),xis omitted. This causes type errors at compile time when the reduced form game is used.Testing
Currently nothing goes wrong as the reduced form game is never used. However, when I replace
singleDecisionPriorVerbosebysingleDecisionPriorReducedon line 168 (in the final gamesingleDecStoch), then the file raises the following error during compilation:Fix
Add
xas an argument in the reduced game. Compilation then works fine with the reduced game, and the correct equilibria are returned: