Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmphoenix: separate math.h from libphoenix (draft) #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

niewim19
Copy link
Contributor

@niewim19 niewim19 commented Feb 3, 2022

JIRA: PD-242

Description

  • Changes that separate math related functions into libmphoenix.a library (analogy to libm.a library)
  • math.h functions are not moved from libphoenix directory

Motivation and Context

  • For Micropython compatibility there are plans of expanding math.h header with more functions (gamma, etc.). Separating mathematic functions into libmphoenix.a library is an avoidance of libphoenix size bloating due to mentioned development plans.
  • Proposed changes were tested on ia32-generic distribution with additional changes in phoenix-rtos-build/Makefile.ia32 so that PHOENIXLIBM variable was added as presented below:
PHOENIXLIB := $(shell $(CC) $(CFLAGS) -print-file-name=libphoenix.a)
PHOENIXLIBM := $(shell $(CC) $(CFLAGS) -print-file-name=libmphoenix.a)
LDLIBS := $(PHOENIXLIB) $(PHOENIXLIBM) $(GCCLIB) $(CRTBEGIN) $(CRTEND)

All changes now available in:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant