Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/select: fix errnos #388

Merged
merged 1 commit into from
Oct 16, 2024
Merged

sys/select: fix errnos #388

merged 1 commit into from
Oct 16, 2024

Conversation

adamgreloch
Copy link
Member

@adamgreloch adamgreloch commented Oct 10, 2024 •
edited
Loading

select() should fail with -1 and set errno to:

  • EBADF when one or more of the fdsets specified an invalid fd
  • EINVAL if nfds is incorrect and/or if timeout makes no sense (i.e. tv_usec is outside of [0, 999999])

JIRA: RTOS-945

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@adamgreloch adamgreloch marked this pull request as ready for review October 10, 2024 16:11
@adamgreloch adamgreloch mentioned this pull request Oct 10, 2024
Merged
14 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

Unit Test Results

7 741 tests  +16   7 026 ✅ +16   39m 51s ⏱️ + 1m 9s
  461 suites +16     715 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit 1f05b97. ± Comparison against base commit fc34b6e.

♻️ This comment has been updated with latest results.

agkaminski
agkaminski reviewed Oct 16, 2024
View reviewed changes
sys/select.c Outdated Show resolved Hide resolved
sys/select.c Outdated Show resolved Hide resolved
sys/select.c Outdated Show resolved Hide resolved
sys/select.c Outdated Show resolved Hide resolved
@adamgreloch
sys/select: fix errnos
1f05b97 
select() should fail with -1 and set errno to:
* EBADF when one or more of the fdsets specified an invalid fd
* EINVAL if nfds is incorrect and/or if timeout makes no sense (i.e.
  tv_usec is outside of [0, 999999])

JIRA: RTOS-945
@adamgreloch adamgreloch mentioned this pull request Oct 16, 2024
Merged
14 tasks
@adamgreloch adamgreloch merged commit 18db069 into master Oct 16, 2024
36 checks passed
@adamgreloch adamgreloch deleted the adamgreloch/RTOS-945 branch October 16, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agkaminski agkaminski agkaminski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamgreloch @agkaminski