Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!toolchain/ld: change arm emul #202

Merged
merged 1 commit into from
Oct 2, 2024
Merged

!toolchain/ld: change arm emul #202

merged 1 commit into from
Oct 2, 2024

Conversation

badochov
Copy link
Contributor

@badochov badochov commented Sep 10, 2024 •
edited
Loading

Previously we defined armelf_phoenix emulation that wasn't used. This patch fixes the configuration to use it.
Additionally support in armelf_phoenix emulation for shared libs is added.

JIRA: RTOS-911

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@badochov badochov marked this pull request as draft September 10, 2024 09:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

Unit Test Results

7 700 tests   6 985 ✅  37m 48s ⏱️
  436 suites    715 💤
    1 files        0 ❌

Results for commit 82484a1.

♻️ This comment has been updated with latest results.

@badochov badochov mentioned this pull request Sep 10, 2024
Merged
14 tasks
@badochov badochov marked this pull request as ready for review September 11, 2024 09:42
@badochov
Copy link
Contributor Author

Demo of using this change and update to 2.43
phoenix-rtos/phoenix-rtos-project#1161

@badochov badochov changed the title feat(toolchain/ld): change arm emul !toolchain/ld: change arm emul Sep 11, 2024
@badochov badochov mentioned this pull request Sep 11, 2024
Closed
14 tasks
@badochov badochov force-pushed the badochov/arm-linker-script branch 2 times, most recently from 736e8ab to 5afe8db Compare September 16, 2024 18:09
@badochov
!toolchain/ld: change arm emul
82484a1 
Previously we defined armelf_phoenix emulation that wasn't used. This
patch fixes the configuration to use it.
Additionally support in armelf_phoenix emulation for shared libs is
added.

JIRA: RTOS-911
@badochov badochov merged commit 2dc9570 into master Oct 2, 2024
30 checks passed
@badochov badochov deleted the badochov/arm-linker-script branch October 2, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darchiv Darchiv Darchiv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badochov @Darchiv