Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal/ia32: cast operands to correct sizes #589

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

badochov
Copy link
Contributor

Newer binutils versions check closely if asm instructions get operands of correct size.

JIRA: RTOS-912

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Newer binutils versions check closely if asm instructions get operands
of correct size.

JIRA: RTOS-912
Copy link

Unit Test Results

7 700 tests  ±0   6 985 ✅ ±0   37m 56s ⏱️ - 1m 23s
  436 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 7b252e3. ± Comparison against base commit b8de910.

Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This arg should be u16 from the start, really. This is I/O space and using memory pointers for it makes no sense. This hotfix is LGTM nevertheless, just something for the future to think about

@badochov badochov merged commit a19bbc8 into master Sep 23, 2024
30 checks passed
@badochov badochov deleted the badochov/ia32-sizes branch September 23, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants