-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hal/cortex-m: Unify SCB and NVIC into SCS #602
Conversation
bbde21e
to
fb29faf
Compare
JIRA: RTOS-886
fb29faf
to
cdfa00a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Adding @anglov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not checked manually, but looks good
I would suggest to clean up hal_* functions name to match module name in future
Thought about it and I'm not sure about that. nvic/scb function names seem somewhat nice, although it violates our naming convention (prefix is not a module name). @Darchiv I can change that in the scope of this PR, should I? |
Not sure. How will you rename them? |
That's my problem exactly 😄 Pure SCS seems fine to me, though |
SCS is fine, but I think functions should have consistent names, e.g.
Sometimes with
but this doesn't look as easy to read as I thought it would. |
I like your proposition, imho it is readable, sticks to our naming convention better and generally better than the current version. |
JIRA: RTOS-886
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment