-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
busybox: add IPv6 support #75
Conversation
a14f4d7
to
b0d6a03
Compare
b0d6a03
to
0aede7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nitpicks, otherwise LGTM.
0aede7f
to
2e6b2c6
Compare
2e6b2c6
to
bba10b4
Compare
Please rebase |
Add nonblocking option for socket JIRA: COG-42
Change the way ifconfig obtains the IPv6 addresses JIRA: COG-42
bba10b4
to
ffa3cee
Compare
Unit Test Results7 723 tests +23 7 008 ✅ +23 37m 51s ⏱️ -40s Results for commit ffa3cee. ± Comparison against base commit df40217. This pull request removes 1 and adds 24 tests. Note that renamed tests count towards both.
|
Rebased |
+ inet_ntop(AF_INET6, &addr->sin6_addr, addr6, 50); | ||
+ | ||
+ /* Get the prefix length */ | ||
+ unsigned char *c = ((struct sockaddr_in6 *)ifap->ifa_netmask)->sin6_addr.s6_addr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks: -Wdeclaration-after-statement
declared in Makefile.flags
of busybox. For some reason on GCC 9.5 warn is not issued but on gcc 14.2 it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update its also triggered on 9.50 my bad
sockfd6 = xsocket(AF_INET6, SOCK_DGRAM, 0); | ||
- xioctl(sockfd6, SIOCGIFINDEX, &ifr); | ||
- ifr6.ifr6_ifindex = ifr.ifr_ifindex; | ||
- ifr6.ifr6_prefixlen = prefix_len; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This break -Wunused-but-set-variable
on prefix_len which is part of -Wall
Description
route.c
compile by includingnet/ip6_route.h
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment
Add support for IPv6 phoenix-rtos-lwip#93
Add support for IPv6 libphoenix#355