Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbedtls: fix test binaries not being stripped #86

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

nalajcie
Copy link
Member

@nalajcie nalajcie commented Oct 2, 2024

Description

Test binaries were unnecessarily large, with DEBUG=1 they took 140MB on rootfs in total!

Motivation and Context

JIRA: CI-494

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Test binaries were unnecessarily large, with `DEBUG=1` they took 140MB
on rootfs in total!

JIRA: CI-494
@nalajcie nalajcie changed the title mbedtls: fix test biaries not being stripped mbedtls: fix test binaries not being stripped Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Unit Test Results

7 723 tests  ±0   7 008 ✅ ±0   40m 5s ⏱️ + 2m 6s
  443 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 043f335. ± Comparison against base commit 707ec1d.

@nalajcie nalajcie merged commit 549e10b into master Oct 2, 2024
34 checks passed
@nalajcie nalajcie deleted the nalajcie/fix_debug branch October 2, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants