Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!build: forcefully disable DEBUG for ports #87

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

nalajcie
Copy link
Member

@nalajcie nalajcie commented Oct 2, 2024

Description

DEBUG is a common env variable in OSS programs to build unstripped/not-optimized/with-debug-info binaries - we almost never want to do it.

JIRA: CI-494

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

`DEBUG` is a common env variable in OSS programs to build
unstripped/not-optimized/with-debug-info binaries - we almost never want
to do it.

JIRA: CI-494
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Not following: ./phoenix-rtos-ports/build.subr: openBinaryFile: does not exist (No such file or directory) SC1091

source "${PREFIX_PROJECT}/phoenix-rtos-ports/build.subr"

Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an exclamation mark in commit message, I'd prefer to remove it before merge. Except that it's done intentionally (?)

@nalajcie
Copy link
Member Author

nalajcie commented Oct 2, 2024

There is an exclamation mark in commit message, I'd prefer to remove it before merge. Except that it's done intentionally (?)

We prefix commit message title of breaking changes with ! to easily spot them in git history (commit message body should have info what / how it could break).

Copy link

github-actions bot commented Oct 2, 2024

Unit Test Results

7 723 tests  ±0   7 008 ✅ ±0   38m 6s ⏱️ +7s
  443 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit efc9853. ± Comparison against base commit 707ec1d.

@nalajcie nalajcie merged commit 6d54d47 into master Oct 2, 2024
34 checks passed
@nalajcie nalajcie deleted the nalajcie/fix_debug2 branch October 2, 2024 13:06
@damianloew
Copy link
Contributor

There is an exclamation mark in commit message, I'd prefer to remove it before merge. Except that it's done intentionally (?)

We prefix commit message title of breaking changes with ! to easily spot them in git history (commit message body should have info what / how it could break).

Sure, that's the first time I saw this, I will remember for the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants