-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!build: forcefully disable DEBUG for ports #87
Conversation
`DEBUG` is a common env variable in OSS programs to build unstripped/not-optimized/with-debug-info binaries - we almost never want to do it. JIRA: CI-494
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an exclamation mark in commit message, I'd prefer to remove it before merge. Except that it's done intentionally (?)
We prefix commit message title of breaking changes with |
Sure, that's the first time I saw this, I will remember for the future |
Description
DEBUG
is a common env variable in OSS programs to build unstripped/not-optimized/with-debug-info binaries - we almost never want to do it.JIRA: CI-494
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment