libc: add tests for functions from math.h #210

mateusz-bloch · 2023-05-24T09:42:00Z

JIRA CI-277
The pull request will be closed and replaced with: #237

Description

Motivation and Context

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: (list targets here).

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work (list the PRs, preferably in merge-order).
I will merge this PR by myself when appropriate.

adamdebek

All basic tests should be replaced with test that will span over whole double range.

libc/math/math.c

libc/Makefile

libc/math/math.c

adamdebek · 2023-07-20T10:45:36Z

libc/math/math.c

+	/* to discuss */
+	// errno = 0;
+	TEST_ASSERT_DOUBLE_IS_NAN(fmod(1, 0.0));
+	// TEST_ASSERT_EQUAL_INT(EDOM, errno);
+
+	// errno = 0;
+	TEST_ASSERT_DOUBLE_IS_NAN(fmod(INFINITY, 1));
+	// TEST_ASSERT_EQUAL_INT(EDOM, errno);


This should be discussed during the meeting , I think if toolchains support IEC 60559 floating point arithmetic then it should be tested.

adamdebek · 2023-07-20T11:37:51Z

libc/math/math.c

+}
+
+
+TEST(math_mod, fmod_special_cond)


I would also add testcase when y is so smallest than epsilon for x.

libc/math/math.c

…rewritten libc: add math.h tests JIRA CI-277

adamdebek · 2023-07-31T16:51:52Z

libc/math/trig_hyper.c

+#define M_SQRT3 1.73205080756887719318
+#define DELTA   1e-05
+
+
+static double dblSubnormal(void)
+{
+	union {
+		double doubleValue;
+		uint64_t integerValue;
+	} representation;
+	representation.integerValue = 0x000fffffffffffffULL;
+	return representation.doubleValue;
+}


This will be redundant since it was only used in basic tests.

adamdebek · 2023-07-31T16:52:29Z

libc/math/trig_hyper.c

+TEST(math_trig, tan_basic)
+{
+	int i;
+	int iterates = 2000;
+	double start = -DBL_MAX;
+	double end = DBL_MAX;
+	double step = (end - start) / (iterates - 1);
+	double x, y;
+
+	for (i = 0; i <= iterates; i++) {
+		x = start + i * step;
+		y = tan(x / 2.0);
+		TEST_ASSERT_EQUAL_DOUBLE(tan(x), (2.0 * y) / (1.0 + y * y));
+	}
+}


I will take care of basic testcases.

adamdebek · 2023-07-31T17:55:54Z

libc/math/trig_hyper.c

+
+TEST(math_trig, tan_special_cond)
+{
+	TEST_ASSERT_DOUBLE_IS_NAN(tan(NAN));


tan() with NAN shouldn' t be tested since we don't support IEC 60559

adamdebek · 2023-07-31T17:58:40Z

libc/math/trig_hyper.c

+	TEST_ASSERT_EQUAL_DOUBLE(0, tan(0.0));
+	TEST_ASSERT_EQUAL_DOUBLE(0, tan(-0.0));
+
+	TEST_ASSERT_EQUAL_DOUBLE(dblSubnormal(), tan(dblSubnormal()));


Subnormal values will be tested in basic tests.

adamdebek · 2023-08-01T08:13:32Z

libc/math/trig_hyper.c

+TEST(math_trig, atan_basic)
+{
+	int i;
+	int iterates = 2000;
+	double start = -1.0;
+	double end = 1.0;
+	double step = (end - start) / (iterates - 1);
+	double x;
+
+	for (i = 0; i <= iterates; i++) {
+		x = start + i * step;
+		TEST_ASSERT_EQUAL_DOUBLE(x, tan(atan(x)));
+	}
+}


adamdebek · 2023-08-02T10:07:01Z

libc/math/trig_hyper.c

+	TEST_ASSERT_EQUAL_DOUBLE(1, cosh(1.0e-6));
+	TEST_ASSERT_EQUAL_DOUBLE(1, cosh(-1.0e-6));
+
+	TEST_ASSERT_EQUAL_DOUBLE(1, cosh(DBL_MIN));


DBL_MIN shouldn't be tested, it is not standardized that it should return 1.0 .

adamdebek · 2023-08-02T10:08:17Z

libc/math/trig_hyper.c

+TEST(math_hyper, sinh_huge_x)
+{
+	TEST_ASSERT_EQUAL_DOUBLE(HUGE_VAL, sinh(1.0e+6));
+	TEST_ASSERT_EQUAL_DOUBLE(-HUGE_VAL, sinh(-1.0e+6));
+
+	TEST_ASSERT_DOUBLE_WITHIN(DELTA, 1e-06, sinh(1.0e-6));
+	TEST_ASSERT_DOUBLE_WITHIN(DELTA, -1e-06, sinh(-1.0e-6));
+
+
+	// TEST_ASSERT_EQUAL_DOUBLE(DBL_MIN, sinh(DBL_MIN));
+	TEST_ASSERT_EQUAL_DOUBLE(HUGE_VAL, sinh(DBL_MAX));
+}


Same as cosh().

adamdebek · 2023-08-02T10:10:59Z

libc/math/trig_hyper.c

+TEST(math_hyper, tanh_huge_x)
+{
+	// TEST_ASSERT_EQUAL_DOUBLE(1, tanh(1.0e+6));
+	// TEST_ASSERT_EQUAL_DOUBLE(-1, tanh(-1.0e+6));
+
+	// TEST_ASSERT_EQUAL_DOUBLE(1e-10, tanh(1.0e-10)); // Sprawdź do którego bitu ma być uwzględnione
+	// TEST_ASSERT_EQUAL_DOUBLE(-1e-10, tanh(-1.0e-10)); // Sprawdź do którego bitu ma być uwzględnione
+
+	// TEST_ASSERT_EQUAL_DOUBLE(1, tanh(INT_MAX));
+	// TEST_ASSERT_EQUAL_DOUBLE(-1, tanh(INT_MIN));
+
+	// TEST_ASSERT_EQUAL_DOUBLE(1, tanh(DBL_MAX));
+	// TEST_ASSERT_EQUAL_DOUBLE(DBL_MIN, tanh(DBL_MIN));
+}


Same as other hyper functions.

adamdebek · 2023-08-02T10:11:45Z

libc/math/trig_hyper.c

+
+TEST(math_hyper, tanh_special_cond)
+{
+	// TEST_ASSERT_EQUAL_DOUBLE(NAN, tanh(NAN)); IMX, ZYNQ-QEMU


Don't check NAN since we don't support IEC 60559.

adamdebek · 2023-08-02T10:12:00Z

libc/math/trig_hyper.c

+	// TEST_ASSERT_EQUAL_DOUBLE(1, tanh(INFINITY));
+	// TEST_ASSERT_EQUAL_DOUBLE(-1, tanh(-INFINITY));
+
+	// TEST_ASSERT_EQUAL_DOUBLE(dblSubnormal(), tanh(dblSubnormal()));


Subnormal will be tested in basic tests.

mateusz-bloch changed the title ~~libc: add functions from math.h tests~~ libc: add tests for functions from math.h May 24, 2023

mateusz-bloch force-pushed the mateusz-bloch/libc_math.h_tests branch 10 times, most recently from e351fda to afcc1c1 Compare July 7, 2023 10:21

damianloew requested a review from adamdebek July 10, 2023 08:54

mateusz-bloch force-pushed the mateusz-bloch/libc_math.h_tests branch 4 times, most recently from f2098c4 to e1fc824 Compare July 10, 2023 16:18

mateusz-bloch marked this pull request as ready for review July 10, 2023 16:27

mateusz-bloch marked this pull request as draft July 10, 2023 16:27

mateusz-bloch force-pushed the mateusz-bloch/libc_math.h_tests branch from e1fc824 to 4474cb6 Compare July 14, 2023 15:24

mateusz-bloch requested a review from damianloew July 17, 2023 08:59

adamdebek requested changes Jul 20, 2023

View reviewed changes

mateusz-bloch force-pushed the mateusz-bloch/libc_math.h_tests branch 5 times, most recently from ea80603 to 5a9f4ff Compare July 26, 2023 09:51

marking elements to investigate or issue | basic tests will still be …

fc784bd

…rewritten libc: add math.h tests JIRA CI-277

mateusz-bloch force-pushed the mateusz-bloch/libc_math.h_tests branch from 5a9f4ff to fc784bd Compare July 26, 2023 10:03

change trig_hyper basic tests

48ae7f8

adamdebek reviewed Aug 2, 2023

View reviewed changes

mateusz-bloch closed this Aug 11, 2023

mateusz-bloch deleted the mateusz-bloch/libc_math.h_tests branch January 31, 2024 18:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libc: add tests for functions from math.h #210

libc: add tests for functions from math.h #210

mateusz-bloch commented May 24, 2023 •

edited

Loading

adamdebek left a comment

adamdebek Jul 20, 2023

adamdebek Jul 20, 2023

adamdebek Jul 31, 2023

adamdebek Jul 31, 2023

adamdebek Jul 31, 2023

adamdebek Jul 31, 2023

adamdebek Aug 1, 2023

adamdebek Aug 2, 2023

adamdebek Aug 2, 2023

adamdebek Aug 2, 2023

adamdebek Aug 2, 2023

adamdebek Aug 2, 2023

		}


		TEST(math_mod, fmod_special_cond)

libc: add tests for functions from math.h #210

libc: add tests for functions from math.h #210

Conversation

mateusz-bloch commented May 24, 2023 • edited Loading

Description

Motivation and Context

Types of changes

How Has This Been Tested?

Checklist:

Special treatment

adamdebek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mateusz-bloch commented May 24, 2023 •

edited

Loading