Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunner: enable colorful logs #222

Merged
merged 1 commit into from
Jul 12, 2023
Merged

trunner: enable colorful logs #222

merged 1 commit into from
Jul 12, 2023

Conversation

mateusz-bloch
Copy link
Member

@mateusz-bloch mateusz-bloch commented Jul 10, 2023 •
edited by damianloew
Loading

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_colorama branch from b586230 to 591ecde Compare July 10, 2023 18:04
@nalajcie
Copy link
Member

hmm, maybe write in commit message what functionality you're adding/changing instead of technical details (eg. trunner: enable colorful logs) for better commit history ;)

@mateusz-bloch mateusz-bloch changed the title trunner: add colorama trunner: enable colorful logs Jul 11, 2023
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_colorama branch from 591ecde to de43555 Compare July 11, 2023 16:32
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_colorama branch from de43555 to 99a004e Compare July 11, 2023 16:35
@mateusz-bloch mateusz-bloch marked this pull request as ready for review July 11, 2023 16:35
damianloew
damianloew approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tip for the future: please always mark those checks, when a PR is ready:

  • All new and existing linter checks and tests passed
  • My changes generate no new compilation warnings for any of the targets.

@damianloew damianloew merged commit 9a48418 into master Jul 12, 2023
27 checks passed
@damianloew damianloew deleted the mateusz-bloch/trunner_add_colorama branch July 12, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianloew damianloew damianloew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateusz-bloch @nalajcie @damianloew