Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libc: stat tests improvements #226

Merged
merged 2 commits into from
Jul 26, 2023
Merged

libc: stat tests improvements #226

merged 2 commits into from
Jul 26, 2023

Conversation

mateusz-bloch
Copy link
Member

JIRA CI-302

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@mateusz-bloch mateusz-bloch marked this pull request as ready for review July 20, 2023 13:38
@mateusz-bloch mateusz-bloch changed the title libc: fix checking times in stat tests libc: stat tests improvements Jul 21, 2023
@mateusz-bloch mateusz-bloch linked an issue Jul 21, 2023 that may be closed by this pull request
libc: stat tests: assert whole st_mode in all stat_mode test cases #220
Closed
@mateusz-bloch mateusz-bloch marked this pull request as draft July 21, 2023 08:54
@mateusz-bloch mateusz-bloch changed the title libc: stat tests improvements libc: stat tests improvements [DO NOT MERGE] [WAITING FOR SUBMODULE UPDATE] Jul 21, 2023
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/libc_fix_times_stat branch from 747bb47 to cd69155 Compare July 25, 2023 09:06
@mateusz-bloch mateusz-bloch changed the title libc: stat tests improvements [DO NOT MERGE] [WAITING FOR SUBMODULE UPDATE] libc: stat tests improvements Jul 25, 2023
@mateusz-bloch mateusz-bloch marked this pull request as ready for review July 25, 2023 09:14
@damianloew damianloew merged commit 972e3c9 into master Jul 26, 2023
25 checks passed
@damianloew damianloew deleted the mateusz-bloch/libc_fix_times_stat branch July 26, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianloew damianloew damianloew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libc: stat tests: assert whole st_mode in all stat_mode test cases
2 participants
@mateusz-bloch @damianloew