Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunner: phoenixd usb lookup #228

Merged
merged 1 commit into from
Aug 7, 2023
Merged

trunner: phoenixd usb lookup #228

merged 1 commit into from
Aug 7, 2023

Conversation

maska989
Copy link
Contributor

@maska989 maska989 commented Jul 20, 2023 •
edited
Loading

Description

trunner: check the solution using vid, pid instead of device name for plo

Motivation and Context

JIRA: CI-304

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@maska989 maska989 requested a review from damianloew July 20, 2023 13:29
@maska989 maska989 marked this pull request as ready for review July 20, 2023 13:50
mateusz-bloch
mateusz-bloch reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@mateusz-bloch mateusz-bloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

nalajcie
nalajcie reviewed Jul 20, 2023
View reviewed changes
trunner/tools/phoenix.py Outdated Show resolved Hide resolved
nalajcie
nalajcie reviewed Jul 20, 2023
View reviewed changes
trunner/tools/phoenix.py Outdated Show resolved Hide resolved
@mateusz-bloch mateusz-bloch changed the title truner: phoenixd usb lookup trunner: phoenixd usb lookup Jul 21, 2023
@maska989 maska989 force-pushed the Maska989/PhoenixdUsbSearch branch 2 times, most recently from 976a823 to 7166cec Compare July 25, 2023 11:35
@maska989 maska989 requested a review from nalajcie July 25, 2023 15:47
nalajcie
nalajcie reviewed Jul 25, 2023
View reviewed changes
trunner/tools/phoenix.py Outdated Show resolved Hide resolved
trunner/tools/phoenix.py Outdated Show resolved Hide resolved
@maska989 maska989 force-pushed the Maska989/PhoenixdUsbSearch branch 3 times, most recently from e01ae01 to 12dad1a Compare July 31, 2023 09:58
@maska989 maska989 requested a review from nalajcie July 31, 2023 10:08
nalajcie
nalajcie reviewed Aug 1, 2023
View reviewed changes
trunner/tools/phoenix.py Outdated Show resolved Hide resolved
@maska989 maska989 requested a review from nalajcie August 1, 2023 12:54
nalajcie
nalajcie approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for the future: dot (.) at the end of the commit message title is not needed

@damianloew damianloew merged commit 0cb61c4 into master Aug 7, 2023
28 checks passed
@damianloew damianloew deleted the Maska989/PhoenixdUsbSearch branch August 7, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalajcie nalajcie nalajcie approved these changes

@damianloew damianloew damianloew approved these changes

@mateusz-bloch mateusz-bloch Awaiting requested review from mateusz-bloch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maska989 @nalajcie @damianloew @mateusz-bloch