-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trunner: phoenixd usb lookup #228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maska989
force-pushed
the
Maska989/PhoenixdUsbSearch
branch
from
July 20, 2023 13:29
3a1f379
to
566b0bd
Compare
maska989
force-pushed
the
Maska989/PhoenixdUsbSearch
branch
from
July 20, 2023 13:52
566b0bd
to
5554b3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
nalajcie
reviewed
Jul 20, 2023
nalajcie
reviewed
Jul 20, 2023
mateusz-bloch
changed the title
truner: phoenixd usb lookup
trunner: phoenixd usb lookup
Jul 21, 2023
maska989
force-pushed
the
Maska989/PhoenixdUsbSearch
branch
from
July 25, 2023 06:44
5554b3d
to
d427ddd
Compare
nalajcie
reviewed
Jul 25, 2023
maska989
force-pushed
the
Maska989/PhoenixdUsbSearch
branch
2 times, most recently
from
July 25, 2023 11:35
976a823
to
7166cec
Compare
nalajcie
reviewed
Jul 25, 2023
maska989
force-pushed
the
Maska989/PhoenixdUsbSearch
branch
3 times, most recently
from
July 31, 2023 09:58
e01ae01
to
12dad1a
Compare
nalajcie
reviewed
Aug 1, 2023
maska989
force-pushed
the
Maska989/PhoenixdUsbSearch
branch
from
August 1, 2023 12:53
12dad1a
to
ccbe328
Compare
nalajcie
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for the future: dot (.
) at the end of the commit message title is not needed
damianloew
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
trunner: check the solution using vid, pid instead of device name for plo
Motivation and Context
JIRA: CI-304
Types of changes
How Has This Been Tested?
Checklist:
Special treatment