-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trunner: add reboot property in yaml #230
Conversation
2d714de
to
b2d9a85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change, please set this property for test-gibber in the separate commit (you can use the same jira id).
20e4973
to
4919a16
Compare
4919a16
to
c2fc387
Compare
32dd50d
to
9755977
Compare
db595cd
to
938e749
Compare
0bf063b
to
3a47fd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO this solution with reboot_next
looks good and thanks to it should_reboot
is passed to the next test only, when there was a fail. @nalajcie could you take a look, whether it's also acceptable for you?
3a47fd8
to
3c0d989
Compare
f1b16a4
to
e7b204d
Compare
e7b204d
to
ecddc8e
Compare
ecddc8e
to
6e9dc80
Compare
JIRA CI-303
JIRA CI-303
ef5267d
to
301dc3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, the current approach is much simpler and more readable, thanks @nalajcie. We didn't want to change a lot of things in the original code, but in this case it was worth it.
JIRA CI-303
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment