Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunner: add reboot property in yaml #230

Merged
merged 2 commits into from
Jul 28, 2023
Merged

trunner: add reboot property in yaml #230

merged 2 commits into from
Jul 28, 2023

Conversation

mateusz-bloch
Copy link
Member

JIRA CI-303

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_reboot_property branch from 2d714de to b2d9a85 Compare July 24, 2023 09:24
@mateusz-bloch mateusz-bloch marked this pull request as ready for review July 24, 2023 09:33
damianloew
damianloew requested changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change, please set this property for test-gibber in the separate commit (you can use the same jira id).

trunner/config.py Outdated Show resolved Hide resolved
psh/test.yaml Outdated Show resolved Hide resolved
psh/test.yaml Show resolved Hide resolved
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_reboot_property branch 3 times, most recently from 20e4973 to 4919a16 Compare July 24, 2023 11:10
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_reboot_property branch from 4919a16 to c2fc387 Compare July 24, 2023 11:23
nalajcie
nalajcie requested changes Jul 24, 2023
View reviewed changes
trunner/test_runner.py Outdated Show resolved Hide resolved
trunner/config.py Outdated Show resolved Hide resolved
trunner/types.py Outdated Show resolved Hide resolved
trunner/test_runner.py Outdated Show resolved Hide resolved
psh/test.yaml Outdated Show resolved Hide resolved
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_reboot_property branch 2 times, most recently from 32dd50d to 9755977 Compare July 24, 2023 12:15
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_reboot_property branch 6 times, most recently from db595cd to 938e749 Compare July 24, 2023 14:25
@damianloew damianloew mentioned this pull request Jul 26, 2023
Merged
13 tasks
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_reboot_property branch 2 times, most recently from 0bf063b to 3a47fd8 Compare July 27, 2023 09:04
damianloew
damianloew reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this solution with reboot_next looks good and thanks to it should_reboot is passed to the next test only, when there was a fail. @nalajcie could you take a look, whether it's also acceptable for you?

trunner/test_runner.py Outdated Show resolved Hide resolved
trunner/test_runner.py Outdated Show resolved Hide resolved
damianloew
damianloew reviewed Jul 27, 2023
View reviewed changes
trunner/test_runner.py Outdated Show resolved Hide resolved
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_reboot_property branch from 3a47fd8 to 3c0d989 Compare July 27, 2023 15:32
nalajcie
nalajcie reviewed Jul 28, 2023
View reviewed changes
trunner/test_runner.py Outdated Show resolved Hide resolved
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_reboot_property branch 3 times, most recently from f1b16a4 to e7b204d Compare July 28, 2023 09:59
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_reboot_property branch from e7b204d to ecddc8e Compare July 28, 2023 10:02
nalajcie
nalajcie reviewed Jul 28, 2023
View reviewed changes
trunner/test_runner.py Outdated Show resolved Hide resolved
trunner/test_runner.py Outdated Show resolved Hide resolved
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_reboot_property branch from ecddc8e to 6e9dc80 Compare July 28, 2023 13:19
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/trunner_add_reboot_property branch from ef5267d to 301dc3e Compare July 28, 2023 13:20
damianloew
damianloew approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the current approach is much simpler and more readable, thanks @nalajcie. We didn't want to change a lot of things in the original code, but in this case it was worth it.

@damianloew damianloew merged commit 03b6e76 into master Jul 28, 2023
28 checks passed
@damianloew damianloew deleted the mateusz-bloch/trunner_add_reboot_property branch July 28, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalajcie nalajcie nalajcie approved these changes

@damianloew damianloew damianloew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateusz-bloch @nalajcie @damianloew