-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trunner: run tests alphabetically #234
trunner: run tests alphabetically #234
Conversation
ac62608
to
24f6106
Compare
trunner/test_runner.py
Outdated
for pattern in ["test*.yaml", "test*.yml"]: | ||
for p in path.rglob(pattern): | ||
if ".git" not in str(p): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe sth like this (not tested):
for pattern in ["test*.yaml", "test*.yml"]: | |
for p in path.rglob(pattern): | |
if ".git" not in str(p): | |
for path in list(path.rglob("test*.yaml")) + list(path.rglob("test*.yml")): | |
if ".git" not in str(p): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be done in one line, but I don't know if it would not lose readability
yamls = [ p for p in list(path.rglob("test*.yaml")) + list(path.rglob("test*.yml")) if ".git" not in str(p) ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave the current solution for readability reasons (as you said).
24f6106
to
1b66533
Compare
JIRA CI-310
1b66533
to
c8f3011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JIRA CI-310
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment