Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psh: improve check psh #235

Merged
merged 1 commit into from
Aug 11, 2023
Merged

psh: improve check psh #235

merged 1 commit into from
Aug 11, 2023

Conversation

mateusz-bloch
Copy link
Member

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@mateusz-bloch mateusz-bloch marked this pull request as ready for review August 8, 2023 13:15
damianloew
damianloew requested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing assert_only_prompt to assert_prompt will be sufficient to avoid fails.

psh/tools/README.md Outdated Show resolved Hide resolved
psh/tools/psh.py Outdated Show resolved Hide resolved
@mateusz-bloch
psh: improve check psh
010cdff 
Improve check for 'psh' when logs from other systems might appear

JIRA CI-316
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/psh_prompt_correct branch from 8127423 to 010cdff Compare August 11, 2023 10:46
@mateusz-bloch mateusz-bloch changed the title psh: adapting tests to situations where there are other logs on output psh: improve check psh Aug 11, 2023
damianloew
damianloew approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damianloew damianloew merged commit 4f793e5 into master Aug 11, 2023
28 checks passed
@damianloew damianloew deleted the mateusz-bloch/psh_prompt_correct branch August 11, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianloew damianloew damianloew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateusz-bloch @damianloew