-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trunner: armv7a9: provide soft restarts #305
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,11 @@ class ARMv7A9TargetRebooter(Rebooter): | |
# TODO add text mode reboot | ||
|
||
def _reboot_soft(self): | ||
self._reboot_hard() | ||
self.host.set_reset(0) | ||
time.sleep(0.5) | ||
self.dut.clear_buffer() | ||
self.host.set_reset(1) | ||
time.sleep(0.25) | ||
Comment on lines
30
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's already defined in the same form in the parent class, so you can just remove it just like it's done there: https://github.com/phoenix-rtos/phoenix-rtos-tests/blob/8c6d062c2fbd327e2664ec371fcf8bddf1135483/trunner/target/armv7m7.py#L21C14-L21C14 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @damianloew look closely on line 32. Same history like before. It needs more time to bring down the target. |
||
|
||
def _reboot_hard(self): | ||
self.host.set_power(False) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understand it's only needed on zynq target, so why do we add it in the common code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On other targets are no impact about that, because construction and way how they change states are different from zynq 7000. On other targets we can easily first up reboot and in this time change state. Zynq7000 need to have to change state as first because it prepares target for what is needed after reboot. I added this code there because it doesn't colidate with other targets and clarify situation with order in flashing state.
This is
Reset cycle
of zynq7000-zedboard:And there is reason why
Reboot
is needed and what types ofSignals
can be needed in this situation:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for a while 0.05s - I've run about 100 restarts and it seemed to work stable - to verify whether it's not possible to make it a bit shorter.