-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GR716: implement flash driver #258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukileczo
force-pushed
the
lukileczo/gr716-flash
branch
6 times, most recently
from
May 31, 2023 12:49
bf7583d
to
30269a7
Compare
lukileczo
force-pushed
the
lukileczo/gr716-flash
branch
from
June 21, 2023 13:42
30269a7
to
e79e347
Compare
lukileczo
force-pushed
the
lukileczo/gr716-flash
branch
2 times, most recently
from
June 21, 2023 13:49
61b61a1
to
4b78e44
Compare
lukileczo
force-pushed
the
lukileczo/gr716-flash
branch
3 times, most recently
from
June 22, 2023 07:47
6bde2fd
to
4862a95
Compare
agkaminski
reviewed
Jun 22, 2023
lukileczo
force-pushed
the
lukileczo/gr716-flash
branch
3 times, most recently
from
July 11, 2023 07:59
f55808e
to
21402b3
Compare
agkaminski
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see one place that might be improved, otherwise LGTM
lukileczo
force-pushed
the
lukileczo/gr716-flash
branch
from
July 13, 2023 14:20
21402b3
to
0c3918f
Compare
agkaminski
reviewed
Jul 14, 2023
lukileczo
force-pushed
the
lukileczo/gr716-flash
branch
2 times, most recently
from
July 14, 2023 11:27
1f3a4b3
to
7a365fe
Compare
JIRA: RTOS-478
lukileczo
force-pushed
the
lukileczo/gr716-flash
branch
from
July 14, 2023 12:04
7a365fe
to
7db1a5a
Compare
agkaminski
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Types of changes
How Has This Been Tested?
sparcv8leon3-gr716-mini
.Checklist:
Special treatment