Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

armv7m: fix DEBUG reset on exception logic #268

Merged
merged 2 commits into from
Jul 13, 2023
Merged

armv7m: fix DEBUG reset on exception logic #268

merged 2 commits into from
Jul 13, 2023

Conversation

agkaminski
Copy link
Member

JIRA: RTOS-489

Description

We want to reset on exception when not DEBUG

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@agkaminski agkaminski mentioned this pull request Jul 13, 2023
Closed
13 tasks
damianloew
damianloew previously approved these changes Jul 13, 2023
View reviewed changes
gerard5
gerard5 previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@gerard5 gerard5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for armv7m looks good to me. btw. I wonder if e.g. armv7a doesn't require adding #ifdef NDEBUG.

@agkaminski agkaminski dismissed stale reviews from gerard5 and damianloew via 9747ffa July 13, 2023 10:10
@agkaminski
Copy link
Member Author

@gerard5 yeah, let's add to all of them while at it

gerard5
gerard5 reviewed Jul 13, 2023
View reviewed changes
hal/ia32/exceptions.c Outdated Show resolved Hide resolved
@agkaminski agkaminski marked this pull request as draft July 13, 2023 10:54
@agkaminski agkaminski marked this pull request as ready for review July 13, 2023 11:52
gerard5
gerard5 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@gerard5 gerard5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Verified on ia32, imxrt1176.

@agkaminski agkaminski merged commit e9ae55a into master Jul 13, 2023
24 checks passed
@agkaminski agkaminski deleted the agkaminski/rtos-489 branch July 13, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerard5 gerard5 gerard5 approved these changes

@damianloew damianloew Awaiting requested review from damianloew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agkaminski @gerard5 @damianloew