Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/erase: make erase confirmation optional at compile-time #348

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

nalajcie
Copy link
Member

@nalajcie nalajcie commented Sep 12, 2024

erase command confirmation will be disabled by default at a compile time.

Description

NOTE: some changes in trunner might be needed, but plo erase command is not being used in testing right now (jffs2 -e might be - and it doesn't require human confirmation ;)).

Motivation and Context

JIRA: NIL-550

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: NIL

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link

Unit Test Results

7 700 tests  ±0   6 985 ✅ ±0   39m 0s ⏱️ + 1m 16s
  436 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit b0b3b2a. ± Comparison against base commit 9787100.

@nalajcie nalajcie merged commit 296a9d4 into master Sep 12, 2024
30 checks passed
@nalajcie nalajcie deleted the nalajcie/erase branch September 12, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants