Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phfs: increase max aliases size to 32 #349

Merged
merged 1 commit into from
Sep 13, 2024
Merged

phfs: increase max aliases size to 32 #349

merged 1 commit into from
Sep 13, 2024

Conversation

nalajcie
Copy link
Member

Description

In complex projects we may have multiple user scripts (FW banking) and applications / blobs. For now increase the max size (RAM in PLO is not a problem).

Motivation and Context

JIRA: NIL-550

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

In complex projects we may have multiple user scripts (FW banking) and
applications / blobs. For now increase the max size (RAM in PLO is not a
problem).

JIRA: NIL-550
Copy link

Unit Test Results

7 700 tests  ±0   6 985 ✅ ±0   38m 58s ⏱️ -17s
  436 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 91bde0c. ± Comparison against base commit 296a9d4.

@nalajcie nalajcie merged commit eb9008f into master Sep 13, 2024
30 checks passed
@nalajcie nalajcie deleted the nalajcie/alias branch September 13, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants