Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal/armv7m: Support RTT as an early console #361

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

Darchiv
Copy link
Member

@Darchiv Darchiv commented Oct 7, 2024

Currently RTT is available as a plo device and also mirrors UART output via hooks. This change makes it possible to replace UART completely by RTT - just define UART_CONSOLE_PLO as empty and keep RTT_ENABLED_PLO truthy (enabled by default).

A print is moved from lib_consoleSet() to console command to avoid output before the first plo log ("Phoenix-RTOS loader ...").

JIRA: RTOS-754

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: imxrt117x-evk.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link

github-actions bot commented Oct 7, 2024

Unit Test Results

7 725 tests  ±0   7 010 ✅ ±0   36m 46s ⏱️ -37s
  445 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit ff9f3ea. ± Comparison against base commit 32fcc3b.

♻️ This comment has been updated with latest results.

@Darchiv Darchiv marked this pull request as ready for review October 7, 2024 11:58
lib/helpers.h Show resolved Hide resolved
lib/helpers.h Show resolved Hide resolved
jmaksymowicz
jmaksymowicz previously approved these changes Oct 7, 2024
Currently RTT is available as a plo device and also mirrors UART output
via hooks. This change makes it possible to replace UART completely by
RTT - just define `UART_CONSOLE_PLO` as empty and keep RTT_ENABLED_PLO
truthy (enabled by default).

A print is moved from `lib_consoleSet()` to console command to avoid
output before the first plo log ("Phoenix-RTOS loader ...").

JIRA: RTOS-754
@Darchiv Darchiv merged commit 36cac49 into master Oct 7, 2024
34 checks passed
@Darchiv Darchiv deleted the Darchiv/RTOS-754 branch October 7, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants