forked from facebookincubator/nimble
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add Stats to Tablet Constants and Renaming (facebookincubator#74)
Summary: Pull Request resolved: facebookincubator#74 Raw size will be implemented in a followup task, to better reflect logical data size that is file format agnostic. # Changes - Adding the optional Stats section to Tablet - ~~`VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing~~ - ~~`FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases.~~ # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called in an if statement. Differential Revision: D60534808
- Loading branch information
1 parent
6f2b241
commit a19ba3b
Showing
3 changed files
with
17 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters