actually warn, don't raise on duplicate ids in LiveViewTest #3603
+35
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Dec 26, 2024
| """ | ||
| else | ||
| detect_duplicate_ids(children, MapSet.put(ids, id)) | ||
| """) |
There was a problem hiding this comment.
We probably want to pass [] as second argument? We don't have a useful stacktrace here, do we?
There was a problem hiding this comment.
sadly no good stacktrace. Changed!
There was a problem hiding this comment.
actually, at least it contains the test, so maybe we should keep it?
warning: Duplicate id found while testing LiveView: foo
<div id="foo"></div>
LiveView requires that all elements have unique ids, duplicate IDs will cause
undefined behavior at runtime, as DOM patching will not be able to target the correct
elements.
(phoenix_live_view 1.0.1) lib/phoenix_live_view/test/dom.ex:47: Phoenix.LiveViewTest.DOM.detect_duplicate_ids/2
(phoenix_live_view 1.0.1) lib/phoenix_live_view/test/dom.ex:36: Phoenix.LiveViewTest.DOM.detect_duplicate_ids/2
(phoenix_live_view 1.0.1) lib/phoenix_live_view/test/dom.ex:28: Phoenix.LiveViewTest.DOM.parse/1
test/phoenix_live_view/test/dom_warn_test.exs:10: Phoenix.LiveViewTest.DOMWarnTest."test parse detects duplicate ids"/1
(ex_unit 1.19.0-dev) lib/ex_unit/runner.ex:511: ExUnit.Runner.exec_test/2
(stdlib 6.1.2) timer.erl:590: :timer.tc/2
(ex_unit 1.19.0-dev) lib/ex_unit/runner.ex:433: anonymous fn/6 in ExUnit.Runner.spawn_test_monitor/4
SteffenDE
force-pushed
the
sd-warn-duplicate-ids-warn
branch
from
f3ab0e5 to
ea68eda
Compare
josevalim
approved these changes
Dec 26, 2024
SteffenDE
force-pushed
the
sd-warn-duplicate-ids-warn
branch
from
ea68eda to
84c8cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3588.
Relates to: #3560.
cc @josevalim