(cherry picked from commit bad068a)

There were surprisingly many `#ifdef` fallbacks for Qt 4.

Removing them simplifies maintenance, as well as adding new GUI
functionality.

(cherry picked from commit 907f73b)

Fix an edge case where autocombine would get stuck if available
UTXOs are low in value compared to autocombine threshold

This file has not been used in quite a while, nuke it from orbit.

Prevent file access collisions and possible file corruption by refusing
to overwrite the current wallet in use.

(cherry picked from commit 908c1d7)

(rebased from bitcoin/bitcoin@fc6a9f2)

This function is never used, and never will be; Nuke it from orbit.

verifychain only accepts a single (optional) argument instead of two,
and we need to capture that argument properly.

Properly return an error when attempting to use a negative timeout. Also
 sanitize the timeout so as to not cause a value error with libevent on
 MacOS.

Even though this command is all but deprecated, it's help output and
example were incorrect and deserving of an update.

amount is the 3rd paramater, and is required. minconf is the 4th
paramater, and for all intents and purposes is a "dummy" paramater since
 it is no longer considered in the functional logic.

When calling `getreceivedbyaddress` with a non-wallet address, return a
proper error code/message instead of `0`

check-doc and logprint-scanner were still using python2 conventions.
This updates the two scripts to use pyhon3 instead and be consistent
with the rest of our python utility scripts.

Also, use a more widely accessible bash path in lint-whitespace.sh

Used primarialy (for now) in node identification for upcoming regtest
scripting.

Simple addition to the JSON output; mainly used in upcoming functional
test updates.

Simple consistency addition. This mimmics the output from `getinfo`.

- Fix git's rev-list call
- Add proper copyright headers from upstream
- Check that the script is in the git tree

This moves CScheduler and threadGroup to a static declaration in init
.cpp so as to avoid a potential shutdown deadlock where both are freed
before the network message handler thread has been completely released.

use c++11 for loops instead of BOOST_FOREACH

- include memory system header for std pointers
- remove unused MutexName
- declare single-argument constructors as explicit

When running the client with the `-disablewallet` option, the staking
and automint icons should always be hidden. This adds a check to see if
`walletFrame` has been set before showing/updating these two icons.

Add Checks for local endian and byteswap support.

Add env prefix to bash scripting

caea417 Update QT to 5.9.7 (cevap)

Tree-SHA512: 34197e7b92711f3f0392b071de58900592ab8bb2ed3e50cd853cf2da56ba2f6d9b3ee57e4d01f3c2cdce4710ebe0c079bba434263b9af65141363086b9213025

…ith gitian

f6c1d4a Add check symbols for gitian-linux.yml (cevap)
4a3d3ea Use pivx in config lines (cevap)
321f0e0 Update linux descriptor (cevap)
4e0244b Update symbol check script (cevap)
c251de5 Update glibc_compat.cpp with risc (cevap)
fb0bdae Gitian: add risc build (cevap)

Tree-SHA512: f91fa1da9c48e3ccb87cb1ddd825d353a15e439b778bd95eb53f22b8884ecb1ddda954a506553dbb8322e931d1b8b34211e1dc7e4b431eafa107d81bdd8e6faa

Addresses https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-6250

Signed-off-by: cevap <dev@i2pmail.org>

Github-Pull: PIVX-Project#858
Rebased-From: 21f5078

Break out a new job to do the basic linting that check-dock.py and
logprint-scanner.py did.

Also add new scripts to check the sanity of
any git subtrees and to check that new pull requests don't contain any
trailing whitespace.

Also, remove the outdated slack notification callback

Also for libsecp256k1 now that it has been updated

This changes the TravisCI behavior to use docker with a Bionic target.
Provides consistency with gitian target.

…56k1'

…update

When the shutdown process is started, it is possible that the call to
`ValidateAccumulatorCheckpoint()` in `ConnectBlock()` will fail. Instead
 of returning an invalid state, which causes the block to pass through
 `InvalidChainFound()`, just return a stateless error if a shutdown has
 been requested.

When `showProgress()` is passed a `100` int value, the dialog is deleted
. If the function is passed a `100` int value a second time in the same
scope, like what happens at the end of `RecalculateZPIVSpent()` and
`RecalculateZPIVSupply()`, it results in a segfault.

This change standardizes the process by first initializing the progress
dialog with a `0` value, updating to a maximum of a `99` value inside
the loop, and finally closing with a `100` value after the loop has
completed.

Small consistency move here so that the number of blocks in a budget
cycle can be defined in chainparams, where most other chain-specific
variables are defined.

The old `masternode` and `mnbudget` commands have been deprecated for
quite some time now, and have had a note in their help descriptions
stating as much. So, time to finally remove them for good.

This changes the TestingSetup fixture to be per-unit-test rather than global.
Most tests don't need it, so it's only invoked in a few.

Make sure that chainparams and logging is properly initialized. Doing
this for every test may be overkill, but this initialization is so
simple that that does not matter.

This should fix the travis issues.

Adds several unittests for addrman to verify it works as expected.
Makes small modifications to addrman to allow deterministic and targeted tests.

Adds several unittests for CAddrMan and CAddrInfo.
Increases the accuracy of addrman tests.
Removes non-determinism in tests by overriding the random number generator.
Extracts testing code from addrman class to test class.

removes the dependency on a specific version, as long as the installed
version is 1.0.x. Also set the appropriate environment flags for OpenSSL
 on macOS.

Note: the setting of these two environment variables would be better
suited to a user's `~/.bash_profile` rather than being done within
CMake, as doing it here is destructive.

This adds extra paths that were left out and ensures that `.gcda` and `
.gcno` files are properly cleaned up.

A timing window exists where a wallet could be creating a new block from within the miner thread when a new block is received to the wallet.  This window will create a situation where TestBlockValidity() fails because the chain tip has changed between the time it created the new block and the time it tested the validity of the block.  

This situation would result in the wallet being asserted; however this is a little overkill.  rather than asserting if the tip has changed, it is better to throw the block away.

This problem was revealed during a testnet test of an altcoin, and very prevalent when multiple wallet existed with the exact same number of staking coins received in the same transaction; or when multiple wallets were staking the same coins via import private key.  The problem happens significantly less in more normal circumstances, but was still observed in a testing environment with fast blocks.

It is likely that this scenario has been encountered but never determined to be root cause, as a crashed wallet could be restarted, re-indexed and never investigated further.

Bumps the gitian build versions to 3.3, which should have been done
right after 3.2 was branched off.

At the same time, update to python3 explicitly and allow for some better
 error reporting.

… Backport from bitcoin#bitcoin#7208.

Most notable change here is the introduction of two breakpoints that
will store the current cache and stop if the previous step took a long
time. This is intended to avoid hitting the global time limit of 50
minutes for builds that would need to rebuild the depends cache.

obfuscationconfig(.h/.cpp) are unused and not needed at all anymore.