Update EpiRoute.php #1591
Open
Update EpiRoute.php #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use openphoto with PHP7, removed break in line 90 : break; // need to simulate same behavior if exceptions are turned off
Deleted break on line 90 to make it work with php7 break; // need to simulate same behavior if exceptions are turned off
|
Thanks @EMarcais. The build failure should be fixed if you rebase from master. Can you also add a comment to this line so someone doesn't turn exceptions off? |
Add comment in line 14 : //let it to true for an install with PHP7 cf: Deleted break on line 90 to make it work with php7 in EpiRoute.php
|
My pleasure, I like what I see from openphoto/trovebox even ! Normally I added the comment correctly in initialize |
modifié : src/libraries/external/epi/EpiRoute.php
Conflicts: src/libraries/external/epi/EpiRoute.php modifié : src/libraries/initialize.php pour coller
Update EpiRoute.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted break on line 90 to make it work with php7
break; // need to simulate same behavior if exceptions are turned off