Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

[BC BREAK] MessageBag does not depend on \ArrayObject anymore #174

Merged
merged 1 commit into from
Dec 28, 2024
Merged

[BC BREAK] MessageBag does not depend on \ArrayObject anymore #174

merged 1 commit into from
Dec 28, 2024

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark self-assigned this Dec 28, 2024
OskarStark
OskarStark commented Dec 28, 2024
View reviewed changes
OskarStark
OskarStark commented Dec 28, 2024
View reviewed changes
@OskarStark OskarStark changed the title MessageBag not depend on \ArrayObject anymore [BC BREK] MessageBag not depend on \ArrayObject anymore Dec 28, 2024
@OskarStark OskarStark added enhancement New feature or request BC BREAK Backwards compatibility break labels Dec 28, 2024
@OskarStark OskarStark mentioned this pull request Dec 28, 2024
Merged
chr-hertel
chr-hertel reviewed Dec 28, 2024
View reviewed changes
chr-hertel
chr-hertel reviewed Dec 28, 2024
View reviewed changes
chr-hertel
chr-hertel reviewed Dec 28, 2024
View reviewed changes
@chr-hertel
Copy link
Member

@OskarStark looks like you have mixed feelings due to missing iterator and array access?

i'm quite positive about this tbh

@OskarStark
Copy link
Contributor Author

Now with the getMessages() its more clear as an API, so I am fine 👍

chr-hertel
chr-hertel approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chr-hertel chr-hertel mentioned this pull request Dec 28, 2024
Closed
@OskarStark OskarStark changed the title [BC BREK] MessageBag not depend on \ArrayObject anymore [BC BREK] MessageBag does not depend on \ArrayObject anymore Dec 28, 2024
@chr-hertel chr-hertel mentioned this pull request Dec 28, 2024
Closed
@chr-hertel chr-hertel changed the title [BC BREK] MessageBag does not depend on \ArrayObject anymore [BC BREAK] MessageBag does not depend on \ArrayObject anymore Dec 28, 2024
@chr-hertel chr-hertel merged commit 3c48f5a into main Dec 28, 2024
7 checks passed
@chr-hertel chr-hertel deleted the feature/no-array branch December 28, 2024 22:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chr-hertel chr-hertel chr-hertel approved these changes

Assignees

@OskarStark OskarStark

Labels
BC BREAK Backwards compatibility break enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OskarStark @chr-hertel