-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement DALL-E image generation for OpenAI Bridge #178
Conversation
2c0a5d3
to
83b3805
Compare
83b3805
to
fc88903
Compare
Thanks @DZunke! Looks pretty good in first glance, will give it a try later - thanks :) |
I would also say it looks good, but didn't test it |
I guess on detailed level Oskar already made some good remarks, taking one step back my first concerns would be more about OOP slicing and naming. In general GenAI is about multi modal content input and output and I wonder what your perspective is about promoting the |
From my PoV the |
fair, and we can generalize later - but on the first research this is pretty unique to DallE, true |
664c839
to
3655afd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DZunke - nice addition :)
Yes, Thanks!!! |
WDYT? Dall-E 3 and Dall-E 2 have the same endpoint for image generation but differ a bit in input and output. I tried to combine it, even i think on the long run, when OpenAI is not deciding to bring Dall-E 3 nearer to Dall-E 2 features, it would profit from splitting the image generation models in their specific classes for type safety but for now it should be fine, from my PoV.
It is not urgent from my side to have this feature, as i already utilize it in a slimmer version in my own code. So, if there is something to think about, just let discuss if there are general ideas for improvements here 😸