JSON Schema needs all properties as "required" #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
OskarStark
force-pushed
the
feature/required-schema
branch
from
5655569 to
b3710cf
Compare
|
not sure i get this - have you been running into issues? this is for structured output after calling tools? |
Ah no not here, but in my other project with my code, but it was more about the schema for a tool description |
|
but still, if you want to change the schema provided for tools, you're patching the wrong class here - anyhow, i will add some tests and maybe unify that parsing stuff 🤔 |
|
lets close it here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on:
Link: https://platform.openai.com/docs/guides/function-calling#example
I am not sure if this is also the case for other platforms/models