Skip to content

Core: fix missing deprecation when accessing null array key with JIT #20883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexandre-daubois merged 3 commits into from
Jan 30, 2026
+6 −3
Merged

Core: fix missing deprecation when accessing null array key with JIT #20883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0905a31
Core: fix missing deprecation when accessing null array key with JIT
alexandre-daubois Jan 9, 2026
3e8a7ef
address Ilija and Dmitry comments
alexandre-daubois Jan 12, 2026
ac8c901
address Ilija comments
alexandre-daubois Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ PHP NEWS
. Fixed bug GH-21059 (Segfault when preloading constant AST closure). (ilutov)
. Fixed bug GH-21072 (Crash on (unset) cast in constant expression).
(arshidkv12)
. Fix deprecation now showing when accessing null key of an array with JIT.
(alexandre-daubois)

- Windows:
. Fixed compilation with clang (missing intrin.h include). (Kévin Dunglas)
Expand Down
3 changes: 1 addition & 2 deletions Zend/Optimizer/sccp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,7 @@ static inline zend_result zval_to_string_offset(zend_long *result, zval *op) {
static inline zend_result fetch_array_elem(zval **result, zval *op1, zval *op2) {
switch (Z_TYPE_P(op2)) {
case IS_NULL:
*result = zend_hash_find(Z_ARR_P(op1), ZSTR_EMPTY_ALLOC());
return SUCCESS;
return FAILURE;
case IS_FALSE:
*result = zend_hash_index_find(Z_ARR_P(op1), 0);
return SUCCESS;
Expand Down
4 changes: 3 additions & 1 deletion ext/opcache/tests/jit/fetch_dim_r_001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,16 @@ function foo() {
}
foo();
?>
--EXPECT--
--EXPECTF--
int(1)
int(3)
int(2)
int(1)
int(3)
int(1)
int(2)

Deprecated: Using null as an array offset is deprecated, use an empty string instead in %s on line %d
int(4)
int(5)
int(5)
Expand Down
Loading