Skip to content

Conversation

@thg2k
Copy link
Contributor

@thg2k thg2k commented Jan 29, 2026

This PR is for PHP-8.4 only, while #21075 is for PHP-8.5 and up.

The fix required for PHP 8.4 branch is different in the two branches, so I'm not sure what is the right PR procedure in this case...

@thg2k thg2k requested a review from kocsismate as a code owner January 29, 2026 10:09
@thg2k thg2k changed the title gen_stub: Fix compatibility with php 7.4 gen_stub: Fix compatibility with php 7.4 (in PHP-8.4) Jan 29, 2026
@TimWolla TimWolla self-assigned this Jan 29, 2026
@TimWolla TimWolla merged commit 23f4b93 into php:PHP-8.4 Jan 29, 2026
10 checks passed
TimWolla added a commit that referenced this pull request Jan 29, 2026
* PHP-8.4:
  gen_stub: Fix compatibility with php 7.4 (in PHP-8.4) (#21076)
TimWolla added a commit that referenced this pull request Jan 29, 2026
* PHP-8.5:
  gen_stub: Fix compatibility with php 7.4 (in PHP-8.4) (#21076)
@thg2k thg2k deleted the pr/genstub84 branch January 29, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants