Skip to content

perf: using constant sizeof instead of strlen #21091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cuiweixie wants to merge 1 commit into from
Closed

perf: using constant sizeof instead of strlen #21091

cuiweixie wants to merge 1 commit into from
+8 −8

Conversation

@cuiweixie
Copy link
Contributor

@cuiweixie cuiweixie commented Jan 30, 2026

No description provided.

@cuiweixie cuiweixie requested a review from bukka as a code owner January 30, 2026 13:08
@iluuu1994
Copy link
Member

iluuu1994 commented Jan 30, 2026

Hi @cuiweixie. strlen() on literals is optimized away by any reasonable compiler. So there's no need for this change.

@iluuu1994 iluuu1994 closed this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees

No one assigned

Labels

Extension: standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cuiweixie @iluuu1994