-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Support GitHub like Markdown Admonitions #1131
Conversation
a97bc04
to
bc539ae
Compare
a604b9e
to
7dbdf74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With respect to backward compatibility I think we should add the AdmonitionNode in guides and make the one in RST
extend from that one.
Same applies to the AdmonitionNodeRenderer that one should be moved to guides and extended in RST for BC purposes.
Otherwise guides will not work with just markdown installed.
Regarding the blockQuoteParser, I think we might need a custom extension for the commonmark library to support this properly. But that's more a nice to have. That we can revisit later.
7dbdf74
to
fbdffed
Compare
I moved extended the classes in the rst. Duh, completely forgot about the node renderer |
fbdffed
to
e90abf4
Compare
e90abf4
to
17a3997
Compare
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
[1.x] Merge pull request #1131 from phpDocumentor/feature/md-admonitions
See https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts
Resolves #1089