Fix RSS subject placeholders in campaign notifications#1103
Open
ashishpatel1992 wants to merge 1 commit intophpList:mainfrom
Open
Fix RSS subject placeholders in campaign notifications#1103ashishpatel1992 wants to merge 1 commit intophpList:mainfrom
ashishpatel1992 wants to merge 1 commit intophpList:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For RSS campaigns, the RssFeedPlugin updates the effective subject during campaign processing, but processqueue.php was still sending notify_start and notify_end emails using the original message subject. As a result, placeholders such as [RSS:N] could appear unprocessed in notification emails.
Updated queue processing to refresh $msgdata['subject'] from the plugin-updatedmessage data after campaignStarted() and after processSendingCampaignFinished().
This keeps non-RSS behaviour unchanged and makes both campaign notificationemails use the final resolved subject.
Changes:
Started Campaign
Before
After
Finishing Campaign
Before
After
Related Issue
Screenshots (if appropriate):