Improve linting and check for compile errors (#292)

* Improve linting and for compile errors

* Check compiled.json is updated

* Avoid duplicating runs by using only push trigger

* Change to go build

.github/workflows/build.yml

@@ -8,14 +8,14 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout 🛎️
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           persist-credentials: false
       -
         name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.19.1
+          go-version: 1.19.6
       - name: Build and Deploy 🚀
         env:
           API_TOKEN_GITHUB: ${{ secrets.API_TOKEN_GITHUB }}
@@ -43,14 +43,14 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout 🛎️
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           persist-credentials: false
       -
         name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.19.1
+          go-version: 1.19.6
       - name: Build and Deploy 🚀
         env:
           API_TOKEN_GITHUB: ${{ secrets.API_TOKEN_GITHUB }}
@@ -78,7 +78,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout 🛎️
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           persist-credentials: false
 
@@ -109,7 +109,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout 🛎️
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           persist-credentials: false
 
@@ -140,7 +140,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout 🛎️
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           persist-credentials: false
 
@@ -171,7 +171,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout 🛎️
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           persist-credentials: false
 
@@ -200,7 +200,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout 🛎️
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           persist-credentials: false
 

.github/workflows/docs.yml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout 🛎️
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           persist-credentials: false
 

.github/workflows/lint.yml

@@ -1,13 +1,64 @@
-name: Lint 
-on: [push, pull_request]
+name: Lint
+on: [push]
 jobs:
   lint:
     name: Lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: actions/setup-node@v1
         with:
-          node-version: '10.x'
+          node-version: "18"
       - run: npm install
       - run: npm run lint
+
+  compare-output:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v1
+        with:
+          node-version: "18"
+      - run: npm install
+      - run: npx swagger-cli bundle -t json -w 300 main.yaml > doc/compiled_new.json
+      - run: diff doc/compiled.json doc/compiled_new.json
+
+  compile-go:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout 🛎️
+        uses: actions/checkout@v3
+        with:
+          persist-credentials: false
+      - name: Set up Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.19.6
+      - name: Build
+        env:
+          API_TOKEN_GITHUB: ${{ secrets.API_TOKEN_GITHUB }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          npm install
+          npm run generate.go
+          cd clients/go && go build
+
+  compile-cli:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout 🛎️
+        uses: actions/checkout@v3
+        with:
+          persist-credentials: false
+      - name: Set up Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.19.6
+      - name: Build
+        env:
+          API_TOKEN_GITHUB: ${{ secrets.API_TOKEN_GITHUB }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          npm install
+          npm run generate.cli
+          cd clients/cli && go build

Makefile

@@ -11,8 +11,8 @@ run:
 	@echo Client libraries generated, check clients directory.
 lint:
 	npx swagger-cli validate main.yaml
-	# make bundle
-	# npx openapi-generator-cli validate -i tmp/compiled.yaml
+	make bundle
+	bash ./lint.sh
 bundle:
 	npx swagger-cli bundle -t json -w 300 main.yaml > doc/compiled.json
 	npx swagger-cli bundle -t yaml -w 300 main.yaml > tmp/compiled.yaml

lint.sh

@@ -0,0 +1,10 @@
+#!/bin/bash
+
+output=$(npx openapi-generator-cli validate -i tmp/compiled.yaml | grep -v "inheritance without use of 'discriminator.propertyName'" | grep -v "No validation issues detected.")
+if echo "$output" | grep -q -E "WARN|ERROR"; then
+    echo "$output"
+    echo "Validation errors"
+    exit 1
+else
+    echo "No validation errors"
+fi