Skip to content

Conversation

@matt-phylum
Copy link
Contributor

MacOS normally installs JDKs in these locations: https://nanova.me/posts/macos-jdk-path

That page also references a ~/.jenv directory which I did not add. I don't know if there's any reason not to add it.

Checklist

  • Does this PR have an associated issue (i.e., closes #<issueNum> in description above)?
  • Have you ensured that you have met the expected acceptance criteria?
  • Have you created sufficient tests?
  • Have you updated all affected documentation?
  • Have you updated CHANGELOG.md (or extensions/CHANGELOG.md), if applicable

@matt-phylum matt-phylum requested a review from a team as a code owner March 3, 2025 18:02
@matt-phylum matt-phylum requested a review from mhorner-vera March 3, 2025 18:02
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Is an exception for the JAVA_HOME environment variable also needed? Or, will having java on the PATH be enough to find and use the JDK?

@matt-phylum
Copy link
Contributor Author

Is JAVA_HOME being removed from the environment variables? I would expect all the existing Java-related exceptions here to fail if we needed it and it was being removed. I don't have JAVA_HOME set in my environment, but mvn is a shell script that sets JAVA_HOME before calling the real mvn...

@matt-phylum
Copy link
Contributor Author

It looks like, at least for Maven, JAVA_HOME is not required. If JAVA_HOME is not set it does a command -v java to locate the JRE.

@matt-phylum matt-phylum merged commit 0591d22 into main Mar 3, 2025
17 checks passed
@matt-phylum matt-phylum deleted the matt/exceptions2 branch March 3, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants