Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse button remapping and addition of supplementary data visualisation #58

Merged
merged 53 commits into from
Jul 8, 2023

Conversation

smoia
Copy link
Member

@smoia smoia commented Jul 8, 2023

Closes #42 #46 #49

Proposed Changes

There's many, among the most important:

  • It is possible to add peaks, not only remove them - by default, the behaviour is left drag remove, right drag add, central button drag exclude signal as bad
  • Physiological objects can get a supplementary timeseries at object initialisation - that helps in viewing multiple physiological processes at once and decide if the peaks in one are true peaks or noise
  • There are more contributors! And contributions.

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

Stefano Moia and others added 30 commits January 22, 2021 18:14
… implement `operation.add_peaks` in the GUI
[FIX] Fixes add_peaks() functionality
… implement `operation.add_peaks` in the GUI
@smoia smoia added the MInormod-breaking For development only, this PR increments the minor version (0.+1.0) but breaks compatibility label Jul 8, 2023
@smoia smoia changed the title A set of major changes that are getting merged at once (check PR text) Mouse button remapping and addition of supplementary data visualisation Jul 8, 2023
@smoia smoia merged commit 2a3dbfb into physiopy:master Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MInormod-breaking For development only, this PR increments the minor version (0.+1.0) but breaks compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants