Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'cli' updater instead of python-apt #477

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Use 'cli' updater instead of python-apt #477

merged 1 commit into from
Aug 27, 2024

Conversation

jcapona
Copy link
Contributor

@jcapona jcapona commented Aug 20, 2024

Status Ticket/Issue
Ready/Hold Ticket

Main changes

Remove usage of python-apt in favor of running apt commands in a shell and parsing output.

  • Update backend to make the 'legacy' updater backend the default.
  • Remove custom mocks used for testing in the backend.
  • Remove option to select updater backend in the frontend.
  • Fix state of updater page on success to display the correct state.

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

Manual testing tips

Tag anyone who definitely needs to review or help

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 86.16352% with 22 lines in your changes missing coverage. Please review.

Project coverage is 76.86%. Comparing base (9214fd4) to head (c342863).

Files Patch % Lines
pt_os_web_portal/os_updater/backend.py 88.97% 14 Missing ⚠️
frontend/src/msw/handlers.ts 0.00% 4 Missing ⚠️
pt_os_web_portal/os_updater/updater.py 83.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
+ Coverage   74.53%   76.86%   +2.33%     
==========================================
  Files         186      183       -3     
  Lines        4182     3942     -240     
  Branches      420      428       +8     
==========================================
- Hits         3117     3030      -87     
+ Misses       1064      911     -153     
  Partials        1        1              
Flag Coverage Δ
js-tests 85.32% <50.00%> (-0.37%) ⬇️
python-tests 71.19% <88.07%> (+3.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapona jcapona force-pushed the remove-apt-py branch 6 times, most recently from 3513fa5 to 550197c Compare August 20, 2024 22:15
@jcapona jcapona marked this pull request as ready for review August 20, 2024 23:19
@jcapona jcapona changed the title Remove apt py Use 'cli' updater instead of python-apt Aug 20, 2024
@jcapona jcapona merged commit 2b50e41 into master Aug 27, 2024
11 checks passed
@jcapona jcapona deleted the remove-apt-py branch August 27, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants