Remove onboarding #485
Merged
Remove onboarding #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #485 +/- ##
==========================================
- Coverage 76.08% 75.39% -0.69%
==========================================
Files 179 178 -1
Lines 3910 3776 -134
Branches 427 389 -38
==========================================
- Hits 2975 2847 -128
+ Misses 934 928 -6
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jcapona
force-pushed
the
SWE-381-os-build-without-onboarding-app
branch
4 times, most recently
from
c602ec4 to
92b997e
Compare
jcapona
force-pushed
the
SWE-381-os-build-without-onboarding-app
branch
from
92b997e to
b4afed0
Compare
angusjfw
reviewed
Apr 4, 2025
angusjfw
reviewed
Apr 4, 2025
| return ( | ||
| <MaskedDiv | ||
| className={cx(styles.closeButtonDiv, className)} | ||
| mask={`url(${closeButtonImage})`} |
There was a problem hiding this comment.
if there is a circle background on this we can make visible i think that would look better. not super important by maybe it's here and transparent
jcapona
force-pushed
the
SWE-381-os-build-without-onboarding-app
branch
2 times, most recently
from
9ffee68 to
1e3ae26
Compare
- Replaced `stopOnboardingAutostart` with `stopFirstBootAppAutostart` across multiple components and services. - Updated close window functionality to use `closeFirstBootAppWindow` instead of `closePtOsLandingWindow`. - Removed deprecated services related to onboarding and landing. - Adjusted API routes to reflect new service names for stopping autostart and closing windows.
jcapona
force-pushed
the
SWE-381-os-build-without-onboarding-app
branch
from
1e3ae26 to
b8dab67
Compare
angusjfw
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
Summary
Detailed changes
Backend:
/route now doesn't check if the device is onboarded or not. It used to do this to redirect users to onboarding when not complete.pt_os_web_portal/app_window/__main__.py, used to start our apps in the devices.OnboardingAppWindow). Check attached screenshots..desktopfile to open the onboarding or landing page.pt-first-boot-app.desktopwhich will open the onboarding or landing depending on the device type.pt-os-setup.desktop.pt-os-landing.desktop/close-first-boot-app-windowroute that closes the 'first time boot' app window in the desktop..desktopfiles./disable-landingroute anddisable_landingmethod since they will not be used anymore./disable-onboardingroute, not used anymore./configure-landingroute andconfigure_landingmethod since they will not be used anymore.pt-os-setup.desktopfile indeprioritise_openbox_sessionfuncton./stop-first-boot-app-autostartroute to handle removingpt-first-boot-app.desktop.Frontend:
restartPagecomponent.finalOnboardingPage(Check attached screenshot).closeButtoncomponent, extracted from the landing page. It's now used in the onboarding & landing when running the app in the device.Screenshots (feature, test output, profiling, dev tools etc)
new 'final' page:
onboarding on legacy devices:
Other notes (e.g. implementation quirks, edge cases, questions / issues)
Manual testing tips
Tag anyone who definitely needs to review or help