Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract shouldn't panick when initState fails #1

Open
noomly opened this issue Sep 15, 2022 · 0 comments
Open

Contract shouldn't panick when initState fails #1

noomly opened this issue Sep 15, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@noomly
Copy link
Contributor

noomly commented Sep 15, 2022 •
edited
Loading

It should return a ContractError when deserializing the state fail instead of ignoring this case using an .unwrap(). See

pianity-smartcontracts-next/erc1155/implementation/src/contract_utils/entrypoint.rs

Line 77 in 6f78209

let state_parsed: State = state.into_serde().unwrap();

@noomly noomly added the enhancement New feature or request label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noomly