Skip to content

Add test against a bug in KokkosKernels batched eigendecomposition #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
terwin wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add test against a bug in KokkosKernels batched eigendecomposition #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be19325
Re-enable eigendecomp test
terwin Feb 19, 2021
278ac1b
Add test exposing KokkosKernels eigendecomp bug
terwin Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 45 additions & 4 deletions unit_test/tstBatchedLinearAlgebra.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

#include <gtest/gtest.h>

#include <algorithm>
#include <array>
#include <random>

using namespace Picasso;
Expand Down Expand Up @@ -711,7 +713,6 @@ void kernelTest()
}

//---------------------------------------------------------------------------//
/*
void eigendecompositionTest()
{
LinearAlgebra::Matrix<double, 4, 4> A = {
Expand Down Expand Up @@ -822,7 +823,43 @@ void eigendecompositionTest()
for ( int j = 0; j < 4; ++j )
EXPECT_FLOAT_EQ( A( i, j ), l_op_ident( i, j ) );
}
*/

//---------------------------------------------------------------------------//
// Test a matrix for which the KokkosKernels eigendecomposition gives the wrong
// answer.
//---------------------------------------------------------------------------//
void eigendecompositionTestBad()
{
LinearAlgebra::Matrix<double, 5, 5> A = { { 0.5, 0.0, 2.5, 0.0, 0.0 },
{ 0.0, 0.5, 0.0, 0.0, 0.0 },
{ 0.0, 0.0, 0.5, 0.0, 0.4 },
{ 0.0, 0.0, 0.0, 0.5, 0.0 },
{ 0.0, 0.0, 1.05, 0.0, 0.5 } };

LinearAlgebra::Vector<double, 5> e_real;
LinearAlgebra::Vector<double, 5> e_imag;
LinearAlgebra::Matrix<double, 5, 5> u_left;
LinearAlgebra::Matrix<double, 5, 5> u_right;

LinearAlgebra::eigendecomposition( A, e_real, e_imag, u_left, u_right );

// All eigenvalues should be real
for ( int i = 0; i < 5; ++i )
EXPECT_EQ( 0.0, e_imag( i ) ) << "i = " << i;

// Sort eigenvalues
std::array<double, 5> sorted_e_real;
for ( int i = 0; i < 5; ++i )
sorted_e_real[i] = e_real( i );
std::sort( sorted_e_real.begin(), sorted_e_real.end() );

// Test sorted eigenvalues
EXPECT_DOUBLE_EQ( -0.14807406984078597, sorted_e_real[0] );
EXPECT_DOUBLE_EQ( 0.5, sorted_e_real[1] );
EXPECT_DOUBLE_EQ( 0.5, sorted_e_real[2] );
EXPECT_DOUBLE_EQ( 0.5, sorted_e_real[3] );
EXPECT_DOUBLE_EQ( 1.148074069840786, sorted_e_real[4] );
}

//---------------------------------------------------------------------------//
// RUN TESTS
Expand Down Expand Up @@ -867,8 +904,12 @@ TEST( TEST_CATEGORY, kernelTest )
kernelTest<20>();
}

// FIXME_KOKKOSKERNELS
// TEST( TEST_CATEGORY, eigendecomposition_test ) { eigendecompositionTest(); }
TEST( TEST_CATEGORY, eigendecomposition_test ) { eigendecompositionTest(); }

TEST( TEST_CATEGORY, eigendecomposition_test_bad )
{
eigendecompositionTestBad();
}

//---------------------------------------------------------------------------//

Expand Down