Updates for R CMD check#28
Conversation
- fix version parsing for old news entries for CRAN check - spelling
There was a problem hiding this comment.
Pull Request Overview
This PR addresses R CMD check notes by updating package metadata, refining documentation and examples, adjusting dependencies, and modernizing the CI workflow.
- Comment out explicit C++11 requirements in Makevars
- Update tests and examples to conditionally skip when
spis unavailable and use"EPSG:XXXX"CRS syntax - Move
spto Suggests, bump RoxygenNote, and adjust roxygen skeleton - Revamp GitHub Actions workflow to use the latest r-lib/actions setup
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-spdf.R | Skip sp tests if missing and update proj4string syntax |
| tests/testthat/test-clhs-gower.R | Add conditional skip for sp in Gower similarity tests |
| src/Makevars.win | Comment out CXX_STD = CXX11 to remove explicit C++11 requirement |
| src/Makevars | Comment out CXX_STD = CXX11 to remove explicit C++11 requirement |
| man/similarity_buffer.Rd | Wrap examples in hide macros and update CRS string syntax |
| README.md | Update R-CMD-check badge to reference new YAML workflow |
| R/similarity.R | Switch to @examplesIf for conditional examples |
| R/clhs-sf.R | Fix backticks around use.coords in error message |
| R/clhs-package.R | Use _PACKAGE tag for roxygen setup |
| R/clhs-data.frame.R | Add drop = FALSE to retain matrix shape in edge-case subsets |
| NEWS.md | Fix typos and standardize version headers |
| DESCRIPTION | Move sp to Suggests and update RoxygenNote |
| .github/workflows/R-CMD-check.yaml | Update CI to r-lib/actions v2–v4 patterns and refine matrix |
Comments suppressed due to low confidence (1)
NEWS.md:27
- [nitpick] Maintain consistent version header formatting in NEWS.md by using an underscore (e.g., clhs_0.7-2) to match historical entries and avoid confusion.
# clhs 0.7-2
|
@brownag Hey Andrew, thanks a lot for the PR! Apologies, I had to satisfy my inner geek and test what Copilot review would look like :) Something I'd like you to do before we merge this, is to add your name to the authors list on the Would you want me to merge #29 at the same time? |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Cool :) I like the summary. I accepted one of the suggestions, but I think we can safely ignore the other two.
Done!
Sure. #29 doesn't really depend on this one but I did base that branch off this just to confirm my changes over there checked cleanly. If this one is merged first it will work fine and just add the few other commits for SpatRaster/SpatVector support. Should not be any major conflicts after merging. |
Hey @pierreroudier!
I wanted to propose some minor updates to {clhs}, so ran it through R CMD check and made some preliminary minor fixes.
use.cpp=TRUEand single column input (a degenerate case I ran into while mocking up a simple example for testing"+init=epsg:XXXX"strings with"EPSG:XXXX"I will be proposing a couple more PRs based on these updates.
Thanks for your consideration, hope you are doing well!!