Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move madrat to Suggests #39

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Move madrat to Suggests #39

merged 7 commits into from
Oct 14, 2024

Conversation

johanneskoch94
Copy link
Member

  • Move madrat to Suggests
  • Bump version

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member 

Not all packages used in your code are listed in DESCRIPTION. The following are missing in file `/code/data-raw/create_internal_sources.R`: countrycode.

Wo er recht hat, hat er recht.

@johanneskoch94
Copy link
Member Author

Danke! (Wie hast du diese Warnung bekommen? Weder devtools::check, noch lucode::buildlibrary hat das bei mir geflagged...)

@johanneskoch94
Fix bug
02d179b 
Fix bug where countries without PPP data were not getting the US conversion factors.
@johanneskoch94
Bump version
f06ed78
@johanneskoch94 johanneskoch94 merged commit 768cd8a into pik-piam:main Oct 14, 2024
3 checks passed
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

Danke! (Wie hast du diese Warnung bekommen? Weder devtools::check, noch lucode::buildlibrary hat das bei mir geflagged...)

https://results.pre-commit.ci/run/github/351750647/1728652479.3pc77C1iSVKkOk7n67dGcg

@johanneskoch94 johanneskoch94 deleted the madratTracking branch October 16, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaviniaBaumstark LaviniaBaumstark LaviniaBaumstark approved these changes

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q Awaiting requested review from 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q

@fbenke-pik fbenke-pik Awaiting requested review from fbenke-pik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johanneskoch94 @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q @LaviniaBaumstark