Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to create a central parameter/function with which we control/set the monetary unit, throughout the magpie/remind pre-processing.
In effect, the crucial part is the monetary unit's base year (our choice of currency, the $, in PPP or MER, not really being up for debate).
Ideally, this function will be called every time monetary values are converted, providing the unit in which the values are to be converted to. The conversion process itself should rely on
GDPuc::convertGDP
(since this function/package will be used for all monetary conversions, the naming should perhaps be revised...). To make the whole process as easy as possible, the proposed function, here calledtoolGetUnitDollar
, would ideally return the exact string that can be passed toGDPuc::convertGDP
'sunit_out
argument.Questions:
toolGetUnit
function?