Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: handle forcecache of length > 1 #217

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

robinhasse
Copy link
Contributor

madrat:::cacheName failed if getConfig("forcecache") had length > 1 and the mode == "puc". I changed the respective condition in the if clause though I would ask you, @tscheypidi, to check if you now expect the intended behaviour.
I had the problem that if I force cache for specific functions by passing a vector of function names, the failure lead to no cache file being written which depending on the settings lead to a failure overall.

Copy link
Member

@tscheypidi tscheypidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing it

@robinhasse robinhasse merged commit 132504a into pik-piam:master Sep 9, 2024
2 checks passed
@robinhasse robinhasse deleted the fixCacheSetting branch September 9, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants