have matchDim(x, ref = NULL) return x #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbenke-pik
reviewed
Jul 2, 2024
|
Looks good to me, but Jan has the final say. |
- add guardians for the type of x, ref, and dim - adjust dim error message to display actual argument - reformat documentation using markdown - use correct class name in documentation
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
force-pushed
the
dev/ignore_NULL_matchDim
branch
from
c82133e to
c55e17c
Compare
tscheypidi
approved these changes
Jul 2, 2024
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
merged commit 1dc9c10
into
pik-piam:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the REMIND reporting, if the reference whose structure some magpie object should match is
NULL, then that magpie object is not going to be used down the line (since we use R variables beingNULLas an indicator for the GAMS model configuration).Just returning
xin that case removes tedious tests and potential errors.